[Observability] Serverless navigation #157139
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
sorenlouv
added
Team:APM - DEPRECATED
💔 Build Failed
Failed CI StepsMetrics [docs]Module Count
Page load bundle
Unknown metric groupsESLint disabled line counts
miscellaneous assets size
Total ESLint disabled count
To update your PR or re-run it, just comment with: |
sorenlouv
force-pushed
the
observability-serverless-nav
branch
from
cc4f422 to
2ffac4f
Compare
sorenlouv
commented
May 9, 2023
| @@ -8,6 +8,9 @@ xpack.securitySolution.enabled: false | |||
| ## Enable the Serverless Obsersability plugin | |||
| xpack.serverless.observability.enabled: true | |||
|
|
|||
| # Onboarding | |||
| xpack.observability_onboarding.ui.enabled: true | |||
sorenlouv
changed the title
kpatticha
reviewed
May 10, 2023
| return <KibanaContextProvider services={services}>{children}</KibanaContextProvider>; | ||
| }; | ||
|
|
||
| export const useKibana = () => useKibanaReact<Services>(); |
There was a problem hiding this comment.
Is this being used anywhere?
kpatticha
reviewed
May 10, 2023
| } from '@kbn/kibana-react-plugin/public'; | ||
| import type { ServerlessObservabilityPluginStartDependencies } from './types'; | ||
|
|
||
| export type Services = CoreStart & ServerlessObservabilityPluginStartDependencies; |
There was a problem hiding this comment.
nit: the type doesn't seem to be used in another file
kpatticha
reviewed
May 10, 2023
| @@ -116,7 +116,7 @@ pageLoadAssetSize: | |||
| security: 65433 | |||
| securitySolution: 66738 | |||
| serverless: 16573 | |||
| serverlessObservability: 16582 | |||
| serverlessObservability: 30000 | |||
There was a problem hiding this comment.
where did this limit come from?
sorenlouv
commented
May 10, 2023
| ## Configure plugins | ||
| xpack.infra.logs.app_target: discover | ||
|
|
||
| ## Set the home route | ||
| uiSettings.overrides.defaultRoute: /app/observability/overview | ||
| uiSettings.overrides.defaultRoute: /app/observabilityOnboarding |
💚 Build Succeeded
Metrics [docs]Module Count
Page load bundle
Unknown metric groupsESLint disabled line counts
miscellaneous assets size
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
|
I'm closing this PR as I'm working on it here: #157360 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #153777
This adds the boilerplate necessary for rendering the serverless nav:
setSideNavComponentAPI from the Serverless plugin.Run this locally:
@elastic/apm-ui